[clang] [clang] Support constexpr bitcasts between equal-size vector and integer types (PR #167016)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: None (Lokesh-Reddy011)

<details>
<summary>Changes</summary>

### Description

This patch fixes an issue where constexpr evaluation failed for bitcasts 
between vector and integer types of equal bit width (e.g., `__m64` ↔ `long 
long`).

The change updates `ExprConstant.cpp` to allow reinterpretation when source and 
destination types have matching bit sizes. In that case, the `APValue` is 
copied directly instead of producing an error.

#### Example

The following code previously failed but now compiles successfully with the 
patch:
```cpp
#include &lt;immintrin.h&gt;

constexpr __m64 foo(__m64 a, int b) {
    return (__m64)(long long)a &lt;&lt; b;
}

int main() {
    foo((__m64){5}, 1);
    return 0;
}
```

#### Testing

* Verified using `clang++ -std=c++20` — works correctly after the patch.
* Test not added to `clang/test` since it requires `&lt;immintrin.h&gt;`, whose 
path varies across systems.


---
Full diff: https://github.com/llvm/llvm-project/pull/167016.diff


1 Files Affected:

- (modified) clang/lib/AST/ExprConstant.cpp (+18-1) 


``````````diff
diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp
index 97eeba8b9d6cc..5b8900f02aeb9 100644
--- a/clang/lib/AST/ExprConstant.cpp
+++ b/clang/lib/AST/ExprConstant.cpp
@@ -17078,7 +17078,24 @@ bool IntExprEvaluator::VisitCastExpr(const CastExpr 
*E) {
   case CK_HLSLAggregateSplatCast:
     llvm_unreachable("invalid cast kind for integral value");
 
-  case CK_BitCast:
+  case CK_BitCast:{
+  APValue Sub;
+  if (!Evaluate(Sub, Info, E->getSubExpr()))
+    return false;
+
+  QualType SrcTy = E->getSubExpr()->getType();
+  QualType DstTy = E->getType();
+
+  // Allow reinterpretation if bit widths match
+  if (Info.Ctx.getTypeSize(SrcTy) == Info.Ctx.getTypeSize(DstTy)) {
+    // Use APValue::BitCast if available, else just copy value bits
+    Result = Sub;
+    return true;
+  }
+
+  return Error(E);
+}
+
   case CK_Dependent:
   case CK_LValueBitCast:
   case CK_ARCProduceObject:

``````````

</details>


https://github.com/llvm/llvm-project/pull/167016
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits