https://github.com/kazutakahirata created 
https://github.com/llvm/llvm-project/pull/167156

Note that addMultilibFlag takes StringRef for its second parameter.

Identified with readability-redundant-string-cstr.


>From 31ed14ebaad73f1a09913d57e8748488d057ad1b Mon Sep 17 00:00:00 2001
From: Kazu Hirata <[email protected]>
Date: Wed, 5 Nov 2025 13:36:04 -0800
Subject: [PATCH] [Driver] Remove extraneous c_str() (NFC)

Note that addMultilibFlag takes StringRef for its second parameter.

Identified with readability-redundant-string-cstr.
---
 clang/lib/Driver/ToolChains/Gnu.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp 
b/clang/lib/Driver/ToolChains/Gnu.cpp
index 7616076847a2c..2dd8cc8422cd7 100644
--- a/clang/lib/Driver/ToolChains/Gnu.cpp
+++ b/clang/lib/Driver/ToolChains/Gnu.cpp
@@ -1750,11 +1750,11 @@ static void findRISCVBareMetalMultilibs(const Driver &D,
   std::string MArch = tools::riscv::getRISCVArch(Args, TargetTriple);
   for (auto Element : RISCVMultilibSet) {
     addMultilibFlag(MArch == Element.march,
-                    Twine("-march=", Element.march).str().c_str(), Flags);
+                    Twine("-march=", Element.march).str(), Flags);
     if (!Added_ABIs.count(Element.mabi)) {
       Added_ABIs.insert(Element.mabi);
       addMultilibFlag(ABIName == Element.mabi,
-                      Twine("-mabi=", Element.mabi).str().c_str(), Flags);
+                      Twine("-mabi=", Element.mabi).str(), Flags);
     }
   }
 

_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to