chh added a comment. If most code can be shared in a common base class like CloexecCheck, maybe all 8 "Add a close-on-exec check" CLs can be combined into 1 or 2 CLs to consolidate all review efforts. I also prefer a separate check name for each function, so users can enable/disable each check.
https://reviews.llvm.org/D35372 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
