probinson added a comment.

Sweet.  I don't have the chops to understand the Objective-C test but otherwise 
LGTM.



================
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1684
+                         HasFile ? getMDOrNull(Record[6]) : nullptr,
+                         HasFile ? Record[4] : 0, getMDString(Record[5]))),
         NextMetadataNo);
----------------
That's a nice touch.


https://reviews.llvm.org/D35583



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to