https://github.com/davidstone created https://github.com/llvm/llvm-project/pull/169385
None >From 1c923448e4a4618b67c51d6fedd80275bf5d0e0e Mon Sep 17 00:00:00 2001 From: David Stone <[email protected]> Date: Mon, 24 Nov 2025 11:30:51 -0700 Subject: [PATCH] [clang][NFC] Don't copy into a vector just to iterate in `IsInitListMemberExprInitialized`. --- clang/lib/Sema/SemaDeclCXX.cpp | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp index 8030aac3d8771..3bc748969065a 100644 --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -3782,21 +3782,21 @@ namespace { if (CheckReferenceOnly && !ReferenceField) return true; - llvm::SmallVector<unsigned, 4> UsedFieldIndex; // Discard the first field since it is the field decl that is being // initialized. - for (const FieldDecl *FD : llvm::drop_begin(llvm::reverse(Fields))) - UsedFieldIndex.push_back(FD->getFieldIndex()); - - for (auto UsedIter = UsedFieldIndex.begin(), - UsedEnd = UsedFieldIndex.end(), - OrigIter = InitFieldIndex.begin(), - OrigEnd = InitFieldIndex.end(); - UsedIter != UsedEnd && OrigIter != OrigEnd; ++UsedIter, ++OrigIter) { - if (*UsedIter < *OrigIter) + auto UsedFields = llvm::drop_begin(llvm::reverse(Fields)); + auto UsedIter = UsedFields.begin(); + const auto UsedEnd = UsedFields.end(); + + for (const unsigned Orig : InitFieldIndex) { + if (UsedIter == UsedEnd) + break; + const unsigned UsedIndex = (*UsedIter)->getFieldIndex(); + if (UsedIndex < Orig) return true; - if (*UsedIter > *OrigIter) + if (UsedIndex > Orig) break; + ++UsedIter; } return false; _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
