philnik777 wrote: > > I think #165682 is removing all the builtins implemented here. > > @philnik777 Thanks for letting me know. Just to clarify, my PR is > implementing CIR lowering for these builtins, not modifying Clang's builtin > definitions themselves. But you raised a good point that if #165682 removes > these x86 builtins from Clang upstream, CIR would need to adapt.
Yes, exactly. AFAICT you're implementing functionality which will be removed. More generally, you might want to check whether any builtins generate platform-specific IR instructions. If no, there is (or should) probably be a generic version, which the x86 builtins can use instead. That way, instead of adding code, you might actually remove code to implement new features. > Btw, what's the current status of your PR? I expect it will land within the next few days. https://github.com/llvm/llvm-project/pull/169310 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
