HighCommander4 wrote:

> > keeping around a `SmallSet<FunctionDecl*> SeenForwardingFuncInstances`
> 
> Is this right? Shouldn't it be a map mapping the declaration to the 
> constructors? Because if I run across for example `make_unique<Foo>` a 2nd 
> time I indeed do not need to traverse its body again, but I still need to 
> record the current location as a reference to the constructor of `Foo`, right?

Yes, you're right, this cache should be a map from forwarding-function 
instances to constructors, just like in the AST case. My bad!

https://github.com/llvm/llvm-project/pull/169742
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to