dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.

Sorry for the delay! This looks good to me.

We have a really embarrassing FIXMELATER from 2012 (!!!) that disabled the 
plist tests for diagnostics. This means we're not getting testing for the 
diagnostic text itself. Let's not block this patch on fixing that, though.


Repository:
  rL LLVM

https://reviews.llvm.org/D35613



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to