danielcdh marked an inline comment as done.
danielcdh added a comment.

Thanks for the review!

In https://reviews.llvm.org/D35746#822498, @chandlerc wrote:

> LGTM with a tiny tweak below.
>
> Would be good to add a test that this flag is being honored, either in this 
> patch or in a follow-up.


I'll add the test in a follow-up patch. Could you help suggest how to add a 
test for this? Shall I just invoke "clang -cc1 -fexperimental-new-pass-manager" 
and check if discriminator is generated? That seems an integration test.


https://reviews.llvm.org/D35746



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to