[clang] [clang-tools-extra] [clang-tidy] `bugprone-unchecked-optional-access`: handle inheritance from `BloombergLP::bslstl::Optional_Base` to prevent false-positives for allocator-aware BDE types (PR #168863)

[Jan Voung via cfe-commits]

================
@@ -78,6 +78,12 @@ static bool hasOptionalClassName(const CXXRecordDecl &RD) {
                             isFullyQualifiedNamespaceEqualTo(*N, "folly"));
   }
 
+  if (RD.getName() == "Optional_Base") {
----------------
jvoung wrote:

Do you know if the check earlier "isFullyQualifiedNamespaceEqualTo(*N, "bsl");" 
is still needed (line 70), if in one case the methods are inherited from 
std::optional, and the other case inherited from  the Optional_Base ?

https://github.com/llvm/llvm-project/pull/168863
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits