carlobertolli wrote: > > I think using a string for a user-facing interface is a bad design. The > > Sema check also doesn't check whether the scope string is valid or not. > > This should be something like a memory order value for those GCC atomic > > builtins. > > Unfortunately we're stuck with a mixed set of atomic builtins with an enum > and others with a string scope name as it is. I'm not sure if it's better to > double down on one direction or the other
Agreed. This PR provides a solution to a user request. It is not meant to be used as a design point: using existing infrastructure/syntax/etc. is deliberate and the goal is not to set a strategic direction for future more comprehensive designs. https://github.com/llvm/llvm-project/pull/172090 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
