https://github.com/tahonermann commented:
@elizabethandrews, I think this is looking good. A question before I fully review though. Does the change to default the target to `spirv64-unknown-unknown` work for both cc1 `-fsycl-is-device` and driver `-fsycl-device-only` invocations? If so, two thoughts: - Should we remove the explicit target for most of the tests since they match the default anyway? - I think a driver test would be appropriate; perhaps one like the existing `cuda-device-triple.cu` that validates both default and explicit target selection. Perhaps we should also update existing tests that specify `spir64` as the device target to use `spirv64-unknown-unknown` (or rely on the default) for consistency? https://github.com/llvm/llvm-project/pull/172366 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
