On Tue, Aug 1, 2017 at 4:34 PM, Hans Wennborg <h...@chromium.org> wrote: > Merged in r309764. > > You cc'd me on the bug, so I noticed that :-) > > Just marking a bug a release blocker doesn't generally work though; it > needs to be marked as blocking PR33849. (Though I will search for > "release blocker" severity bugs now and then.) > > On Tue, Aug 1, 2017 at 3:15 PM, Bruno Cardoso Lopes > <bruno.card...@gmail.com> wrote: >> Hi Hans, >> >> Can we merge this to 5.0 too? I tried to set up the bugzilla to mark >> it as "release blocker", is that enough for you to see it? or next >> time is something I can do to make your life easier?
Cool, thanks again! >> Thanks, >> >> On Tue, Aug 1, 2017 at 3:10 PM, Bruno Cardoso Lopes via cfe-commits >> <cfe-commits@lists.llvm.org> wrote: >>> Author: bruno >>> Date: Tue Aug 1 15:10:36 2017 >>> New Revision: 309752 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=309752&view=rev >>> Log: >>> [Headers][Darwin] Allow #include_next<float.h> to work on Darwin prior to >>> 10.7 >>> >>> This fixes PR31504 and it's a follow up from adding #include_next<float.h> >>> for Darwin in r289018. >>> >>> rdar://problem/29856682 >>> >>> Modified: >>> cfe/trunk/lib/Headers/float.h >>> >>> Modified: cfe/trunk/lib/Headers/float.h >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Headers/float.h?rev=309752&r1=309751&r2=309752&view=diff >>> ============================================================================== >>> --- cfe/trunk/lib/Headers/float.h (original) >>> +++ cfe/trunk/lib/Headers/float.h Tue Aug 1 15:10:36 2017 >>> @@ -33,6 +33,15 @@ >>> */ >>> #if (defined(__APPLE__) || (defined(__MINGW32__) || defined(_MSC_VER))) && >>> \ >>> __STDC_HOSTED__ && __has_include_next(<float.h>) >>> + >>> +/* Prior to Apple's 10.7 SDK, float.h SDK header used to apply an extra >>> level >>> + * of #include_next<float.h> to keep Metrowerks compilers happy. Avoid this >>> + * extra indirection. >>> + */ >>> +#ifdef __APPLE__ >>> +#define _FLOAT_H_ >>> +#endif >>> + >>> # include_next <float.h> >>> >>> /* Undefine anything that we'll be redefining below. */ >>> >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> cfe-commits@lists.llvm.org >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> >> >> >> -- >> Bruno Cardoso Lopes >> http://www.brunocardoso.cc -- Bruno Cardoso Lopes http://www.brunocardoso.cc _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits