https://github.com/boomanaiden154 created 
https://github.com/llvm/llvm-project/pull/173335

Now that the internal shell is enabled everywhere by default, the shell feature 
makes little sense and essentially only implies windows is unsupported. These 
tests all already require specific POSIX systems, so the feature is no-op. 
Remove them to eventually remove the shell feature from lit.

>From 3b1da5c5a253bba74e7b3ee0e886519a6cb042e7 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <[email protected]>
Date: Tue, 23 Dec 2025 06:35:40 +0000
Subject: [PATCH] [Clang] Remove remaining REQUIRES: shell statements

Now that the internal shell is enabled everywhere by default, the shell
feature makes little sense and essentially only implies windows is
unsupported. These tests all already require specific POSIX systems, so
the feature is no-op. Remove them to eventually remove the shell feature
from lit.
---
 clang/test/Analysis/z3-crosscheck-max-attempts.cpp | 2 +-
 clang/test/Analysis/z3/D83660.c                    | 2 +-
 clang/test/Modules/crash-vfs-relative-incdir.m     | 2 +-
 clang/test/Modules/crash-vfs-run-reproducer.m      | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/clang/test/Analysis/z3-crosscheck-max-attempts.cpp 
b/clang/test/Analysis/z3-crosscheck-max-attempts.cpp
index ab66fe94582b3..5cc85d4f406ee 100644
--- a/clang/test/Analysis/z3-crosscheck-max-attempts.cpp
+++ b/clang/test/Analysis/z3-crosscheck-max-attempts.cpp
@@ -27,7 +27,7 @@
 // RUN: env Z3_SOLVER_RESULTS="UNDEF,UNDEF,SAT"   %{mocked_clang} 
%{attempts}=3 -verify=accepted
 
 
-// REQUIRES: z3, z3-mock, asserts, shell, system-linux
+// REQUIRES: z3, z3-mock, asserts, system-linux
 
 // refuted-no-diagnostics
 
diff --git a/clang/test/Analysis/z3/D83660.c b/clang/test/Analysis/z3/D83660.c
index a81ce3a63ff16..b4f0539f7e8a7 100644
--- a/clang/test/Analysis/z3/D83660.c
+++ b/clang/test/Analysis/z3/D83660.c
@@ -3,7 +3,7 @@
 // RUN: %clang_analyze_cc1 -analyzer-constraints=z3 \
 // RUN:   -analyzer-checker=core %s -verify
 //
-// REQUIRES: z3, z3-mock, asserts, shell, system-linux
+// REQUIRES: z3, z3-mock, asserts, system-linux
 //
 // Works only with the z3 constraint manager.
 // expected-no-diagnostics
diff --git a/clang/test/Modules/crash-vfs-relative-incdir.m 
b/clang/test/Modules/crash-vfs-relative-incdir.m
index 46c3413c7817f..cacf65a053049 100644
--- a/clang/test/Modules/crash-vfs-relative-incdir.m
+++ b/clang/test/Modules/crash-vfs-relative-incdir.m
@@ -1,4 +1,4 @@
-// REQUIRES: crash-recovery, shell, system-darwin
+// REQUIRES: crash-recovery, system-darwin
 
 // RUN: rm -rf %t
 // RUN: mkdir -p %t/m
diff --git a/clang/test/Modules/crash-vfs-run-reproducer.m 
b/clang/test/Modules/crash-vfs-run-reproducer.m
index fa06fd988c98f..7b289ccc15bd5 100644
--- a/clang/test/Modules/crash-vfs-run-reproducer.m
+++ b/clang/test/Modules/crash-vfs-run-reproducer.m
@@ -1,4 +1,4 @@
-// REQUIRES: crash-recovery, shell, system-darwin
+// REQUIRES: crash-recovery, system-darwin
 
 // RUN: rm -rf %t
 // RUN: mkdir -p %t/i %t/m %t

_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to