================
@@ -0,0 +1,76 @@
+// RUN: %check_clang_tidy -std=c++11-or-later %s readability-trailing-comma %t
-- \
+// RUN: -config='{CheckOptions:
{readability-trailing-comma.InitListThreshold: 1}}'
+
+struct S { int x, y; };
+
+enum E1 { A, B, C };
+// CHECK-MESSAGES: :[[@LINE-1]]:18: warning: enum should have a trailing comma
[readability-trailing-comma]
+// CHECK-FIXES: enum E1 { A, B, C, };
+
+enum class E2 { X, Y };
+// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: enum should have a trailing comma
+// CHECK-FIXES: enum class E2 { X, Y, };
+
+enum E3 { V = 1 };
+// CHECK-MESSAGES: :[[@LINE-1]]:16: warning: enum should have a trailing comma
+// CHECK-FIXES: enum E3 { V = 1, };
+
+// No warnings - already have trailing commas or empty
+enum E4 { P, Q, };
+enum Empty {};
+
+void f() {
+ int a[] = {1, 2};
+ // CHECK-MESSAGES: :[[@LINE-1]]:18: warning: initializer list should have a
trailing comma
+ // CHECK-FIXES: int a[] = {1, 2,};
+
+ S s = {1, 2};
+ // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: initializer list should have a
trailing comma
+ // CHECK-FIXES: S s = {1, 2,};
+
+ int b[] = {1};
+ // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: initializer list should have a
trailing comma
+ // CHECK-FIXES: int b[] = {1,};
+
+ int c[] = {1, 2,};
+ S s2 = {1, 2,};
+ int d[] = {};
+}
+
+struct N { S a, b; };
+
+void nested() {
+ N n = {{1, 2}, {3, 4}};
+ // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: initializer list should have a
trailing comma
+ // CHECK-MESSAGES: :[[@LINE-2]]:23: warning: initializer list should have a
trailing comma
+ // CHECK-MESSAGES: :[[@LINE-3]]:24: warning: initializer list should have a
trailing comma
+
+ N n2 = {{1, 2,}, {3, 4,},};
+}
+
+#define ENUM(n, a, b) enum n { a, b }
+#define INIT {1, 2}
+
+ENUM(E1M, X, Y);
+int macroArr[] = INIT;
+
+enum E2M { Am, Bm };
+// CHECK-MESSAGES: :[[@LINE-1]]:18: warning: enum should have a trailing comma
+// CHECK-FIXES: enum E2M { Am, Bm, };
+
+template <typename T, typename... Ts>
+struct Pack {
+ int values[sizeof...(Ts) + 1] = {sizeof(T), sizeof(Ts)...};
+};
+
+Pack<int> single;
----------------
localspook wrote:
Very much a nitpick, but I feel "one, two, three" reads more smoothly than
"single, two, three"
```suggestion
Pack<int> one;
```
https://github.com/llvm/llvm-project/pull/173669
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
