https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/173969
Allows for type checking depending on the built-in signature. There is no `f32` version for both builtins. From 956bda1c3e633c81d507895a427fe95d19c0ad87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= <[email protected]> Date: Tue, 30 Dec 2025 09:50:38 +0100 Subject: [PATCH 1/2] Pre-commit tests: [Clang] Remove 't' from __builtin_amdgcn_global_atomic_fmin/fmax_f64 --- .../SemaHIP/amdgpu-global-atomic-fmax-err.hip | 23 +++++++++++++++++++ .../SemaHIP/amdgpu-global-atomic-fmin-err.hip | 23 +++++++++++++++++++ 2 files changed, 46 insertions(+) create mode 100644 clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip create mode 100644 clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip diff --git a/clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip b/clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip new file mode 100644 index 0000000000000..633b3649cd608 --- /dev/null +++ b/clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip @@ -0,0 +1,23 @@ +// RUN: %clang_cc1 -fsyntax-only -triple amdgcn -target-cpu gfx942 -verify %s -fcuda-is-device +// RUN: %clang_cc1 -fsyntax-only -triple x86_64 -aux-triple amdgcn -verify %s +// expected-no-diagnostics + +#define __device__ __attribute__((device)) +#define __shared__ __attribute__((shared)) + +__device__ double global_double; + +__device__ void test_global_atomic_fmax_f64_valid(double *ptr, double val) { + double result; + result = __builtin_amdgcn_global_atomic_fmax_f64(ptr, val); + result = __builtin_amdgcn_global_atomic_fmax_f64(&global_double, val); +} + +__device__ void test_global_atomic_fmax_f64_errors(double *ptr, double val, + __shared__ double *lds_ptr, + float *ptr_f) { + double result; + result = __builtin_amdgcn_global_atomic_fmax_f64(ptr, val, 0); + result = __builtin_amdgcn_global_atomic_fmax_f64(lds_ptr, val); + result = __builtin_amdgcn_global_atomic_fmax_f64(ptr_f, val); +} diff --git a/clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip b/clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip new file mode 100644 index 0000000000000..9cc1e4d31807e --- /dev/null +++ b/clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip @@ -0,0 +1,23 @@ +// RUN: %clang_cc1 -fsyntax-only -triple amdgcn -target-cpu gfx942 -verify %s -fcuda-is-device +// RUN: %clang_cc1 -fsyntax-only -triple x86_64 -aux-triple amdgcn -verify %s +// expected-no-diagnostics + +#define __device__ __attribute__((device)) +#define __shared__ __attribute__((shared)) + +__device__ double global_double; + +__device__ void test_global_atomic_fmin_f64_valid(double *ptr, double val) { + double result; + result = __builtin_amdgcn_global_atomic_fmin_f64(ptr, val); + result = __builtin_amdgcn_global_atomic_fmin_f64(&global_double, val); +} + +__device__ void test_global_atomic_fmin_f64_errors(double *ptr, double val, + __shared__ double *lds_ptr, + float *ptr_f) { + double result; + result = __builtin_amdgcn_global_atomic_fmin_f64(ptr, val, 0); + result = __builtin_amdgcn_global_atomic_fmin_f64(lds_ptr, val); + result = __builtin_amdgcn_global_atomic_fmin_f64(ptr_f, val); +} From 7e24e86dedd9ad86c64b5ff94edf1de0e3b973e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?= <[email protected]> Date: Tue, 30 Dec 2025 09:47:08 +0100 Subject: [PATCH 2/2] [Clang] Remove 't' from __builtin_amdgcn_global_atomic_fmin/fmax_f64 --- clang/include/clang/Basic/BuiltinsAMDGPU.def | 4 ++-- clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip | 5 ++--- clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip | 5 ++--- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/clang/include/clang/Basic/BuiltinsAMDGPU.def b/clang/include/clang/Basic/BuiltinsAMDGPU.def index c4eb91af7933f..37bc4738302b7 100644 --- a/clang/include/clang/Basic/BuiltinsAMDGPU.def +++ b/clang/include/clang/Basic/BuiltinsAMDGPU.def @@ -269,8 +269,8 @@ TARGET_BUILTIN(__builtin_amdgcn_fmed3h, "hhhh", "nc", "gfx9-insts") TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f64, "dd*1d", "", "gfx90a-insts") TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1f", "", "atomic-fadd-rtn-insts") TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_v2f16, "V2hV2h*1V2h", "t", "atomic-buffer-global-pk-add-f16-insts") -TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fmin_f64, "dd*1d", "t", "gfx90a-insts") -TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fmax_f64, "dd*1d", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fmin_f64, "dd*1d", "", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fmax_f64, "dd*1d", "", "gfx90a-insts") TARGET_BUILTIN(__builtin_amdgcn_flat_atomic_fadd_f64, "dd*0d", "", "gfx90a-insts") TARGET_BUILTIN(__builtin_amdgcn_flat_atomic_fmin_f64, "dd*0d", "", "gfx90a-insts") diff --git a/clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip b/clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip index 633b3649cd608..f04c6e3221bcd 100644 --- a/clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip +++ b/clang/test/SemaHIP/amdgpu-global-atomic-fmax-err.hip @@ -1,6 +1,5 @@ // RUN: %clang_cc1 -fsyntax-only -triple amdgcn -target-cpu gfx942 -verify %s -fcuda-is-device // RUN: %clang_cc1 -fsyntax-only -triple x86_64 -aux-triple amdgcn -verify %s -// expected-no-diagnostics #define __device__ __attribute__((device)) #define __shared__ __attribute__((shared)) @@ -17,7 +16,7 @@ __device__ void test_global_atomic_fmax_f64_errors(double *ptr, double val, __shared__ double *lds_ptr, float *ptr_f) { double result; - result = __builtin_amdgcn_global_atomic_fmax_f64(ptr, val, 0); + result = __builtin_amdgcn_global_atomic_fmax_f64(ptr, val, 0); // expected-error{{too many arguments to function call, expected 2, have 3}} result = __builtin_amdgcn_global_atomic_fmax_f64(lds_ptr, val); - result = __builtin_amdgcn_global_atomic_fmax_f64(ptr_f, val); + result = __builtin_amdgcn_global_atomic_fmax_f64(ptr_f, val); // expected-error{{cannot initialize a parameter of type}} } diff --git a/clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip b/clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip index 9cc1e4d31807e..3a63d513113b4 100644 --- a/clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip +++ b/clang/test/SemaHIP/amdgpu-global-atomic-fmin-err.hip @@ -1,6 +1,5 @@ // RUN: %clang_cc1 -fsyntax-only -triple amdgcn -target-cpu gfx942 -verify %s -fcuda-is-device // RUN: %clang_cc1 -fsyntax-only -triple x86_64 -aux-triple amdgcn -verify %s -// expected-no-diagnostics #define __device__ __attribute__((device)) #define __shared__ __attribute__((shared)) @@ -17,7 +16,7 @@ __device__ void test_global_atomic_fmin_f64_errors(double *ptr, double val, __shared__ double *lds_ptr, float *ptr_f) { double result; - result = __builtin_amdgcn_global_atomic_fmin_f64(ptr, val, 0); + result = __builtin_amdgcn_global_atomic_fmin_f64(ptr, val, 0); // expected-error{{too many arguments to function call, expected 2, have 3}} result = __builtin_amdgcn_global_atomic_fmin_f64(lds_ptr, val); - result = __builtin_amdgcn_global_atomic_fmin_f64(ptr_f, val); + result = __builtin_amdgcn_global_atomic_fmin_f64(ptr_f, val); // expected-error{{cannot initialize a parameter of type}} } _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
