https://github.com/ojhunt requested changes to this pull request.
This looks reasonable to me, sans the naming+comment strategy. I'm also curious about the performance impact of this change - I recall having to fight quite a bit at the time. The test case I was using was an overwhelmingly heavy amount of exception dispatch. The parsing itself should have been overwhelmed by the complexity of the dispatch yet I found significant performance regressions. I actually wonder if we should make a pointer wrapper that can handle ptrauth types - it would make the behavior much more explicit and would Just Work (tm) as a parameter by making the argument type non-pod, and the inliner can flatten from there. https://github.com/llvm/llvm-project/pull/173765 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
