================
@@ -760,9 +758,9 @@ struct LessClangTidyError {
const tooling::DiagnosticMessage &M1 = LHS.Message;
const tooling::DiagnosticMessage &M2 = RHS.Message;
- return std::tie(M1.FilePath, M1.FileOffset, LHS.DiagnosticName,
- M1.Message) <
- std::tie(M2.FilePath, M2.FileOffset, RHS.DiagnosticName,
M2.Message);
+ return std::tie(M1.FilePath, M1.FileOffset, M1.Message,
+ LHS.DiagnosticName) <
+ std::tie(M2.FilePath, M2.FileOffset, M2.Message,
RHS.DiagnosticName);
----------------
localspook wrote:
Having `DiagnosticName` (i.e. the check name) last means sorting using this
predicate puts duplicate diagnostics into consecutive runs. This enables us to
do away with the `UniqueErrorSet` in
`removeDuplicatedDiagnosticsOfAliasCheckers`.
https://github.com/llvm/llvm-project/pull/174237
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
