github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h --
clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp
clang-tools-extra/clang-tidy/bugprone/CapturingThisInMemberVariableCheck.cpp
clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp
clang-tools-extra/clang-tidy/bugprone/InvalidEnumDefaultInitializationCheck.cpp
clang-tools-extra/clang-tidy/bugprone/NonZeroEnumToBoolConversionCheck.cpp
clang-tools-extra/clang-tidy/bugprone/OptionalValueConversionCheck.cpp
clang-tools-extra/clang-tidy/bugprone/SuspiciousStringviewDataUsageCheck.cpp
clang-tools-extra/clang-tidy/bugprone/UnsafeFunctionsCheck.cpp
clang-tools-extra/clang-tidy/bugprone/UnusedLocalNonTrivialVariableCheck.cpp
clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
clang-tools-extra/clang-tidy/cppcoreguidelines/NoSuspendWithLockCheck.cpp
clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsAvoidUncheckedContainerAccessCheck.cpp
clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.cpp
clang-tools-extra/clang-tidy/misc/OverrideWithDifferentVisibilityCheck.cpp
clang-tools-extra/clang-tidy/modernize/UseStdFormatCheck.cpp
clang-tools-extra/clang-tidy/modernize/UseStdPrintCheck.cpp
clang-tools-extra/clang-tidy/performance/EnumSizeCheck.cpp
clang-tools-extra/clang-tidy/performance/ForRangeCopyCheck.cpp
clang-tools-extra/clang-tidy/performance/NoAutomaticMoveCheck.cpp
clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitializationCheck.cpp
clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp
clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp
clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp
clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp
clang-tools-extra/clang-tidy/utils/Matchers.h --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git
a/clang-tools-extra/clang-tidy/bugprone/CapturingThisInMemberVariableCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/CapturingThisInMemberVariableCheck.cpp
index 1a9a378e0..5adf8f97e 100644
---
a/clang-tools-extra/clang-tidy/bugprone/CapturingThisInMemberVariableCheck.cpp
+++
b/clang-tools-extra/clang-tidy/bugprone/CapturingThisInMemberVariableCheck.cpp
@@ -96,10 +96,10 @@ void
CapturingThisInMemberVariableCheck::registerMatchers(MatchFinder *Finder) {
lambdaExpr(hasAnyCapture(CaptureThis)).bind("lambda");
auto IsBindCapturingThis =
- callExpr(
-
callee(functionDecl(matchers::matchesAnyListedRegexName(BindFunctions))
- .bind("callee")),
- hasAnyArgument(cxxThisExpr()))
+ callExpr(callee(functionDecl(
+ matchers::matchesAnyListedRegexName(BindFunctions))
+ .bind("callee")),
+ hasAnyArgument(cxxThisExpr()))
.bind("bind");
auto IsInitWithLambdaOrBind =
diff --git a/clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp
index 0cef9a82a..a2a60233d 100644
--- a/clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp
@@ -77,8 +77,8 @@ std::optional<TraversalKind>
EmptyCatchCheck::getCheckTraversalKind() const {
}
void EmptyCatchCheck::registerMatchers(MatchFinder *Finder) {
- auto AllowedNamedExceptionDecl =
-
namedDecl(matchers::matchesAnyListedRegexName(AllowEmptyCatchForExceptions));
+ auto AllowedNamedExceptionDecl = namedDecl(
+ matchers::matchesAnyListedRegexName(AllowEmptyCatchForExceptions));
auto AllowedNamedExceptionTypes =
qualType(anyOf(hasDeclaration(AllowedNamedExceptionDecl),
references(AllowedNamedExceptionDecl),
diff --git
a/clang-tools-extra/clang-tidy/bugprone/OptionalValueConversionCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/OptionalValueConversionCheck.cpp
index d88470492..c1264d03a 100644
--- a/clang-tools-extra/clang-tidy/bugprone/OptionalValueConversionCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/OptionalValueConversionCheck.cpp
@@ -51,10 +51,10 @@ OptionalValueConversionCheck::getCheckTraversalKind() const
{
}
void OptionalValueConversionCheck::registerMatchers(MatchFinder *Finder) {
- auto BindOptionalType = qualType(
- hasCleanType(qualType(hasDeclaration(namedDecl(
-
matchers::matchesAnyListedRegexName(OptionalTypes))))
- .bind("optional-type")));
+ auto BindOptionalType = qualType(hasCleanType(
+ qualType(hasDeclaration(namedDecl(
+ matchers::matchesAnyListedRegexName(OptionalTypes))))
+ .bind("optional-type")));
auto EqualsBoundOptionalType =
qualType(hasCleanType(equalsBoundNode("optional-type")));
@@ -64,10 +64,11 @@ void
OptionalValueConversionCheck::registerMatchers(MatchFinder *Finder) {
cxxOperatorCallExpr(hasOverloadedOperatorName("*"),
hasUnaryOperand(hasType(EqualsBoundOptionalType)))
.bind("op-call"),
- cxxMemberCallExpr(thisPointerType(EqualsBoundOptionalType),
- callee(cxxMethodDecl(anyOf(
- hasOverloadedOperatorName("*"),
-
matchers::matchesAnyListedRegexName(ValueMethods)))))
+ cxxMemberCallExpr(
+ thisPointerType(EqualsBoundOptionalType),
+ callee(cxxMethodDecl(
+ anyOf(hasOverloadedOperatorName("*"),
+ matchers::matchesAnyListedRegexName(ValueMethods)))))
.bind("member-call")),
hasType(qualType().bind("value-type")));
@@ -78,34 +79,35 @@ void
OptionalValueConversionCheck::registerMatchers(MatchFinder *Finder) {
ignoringImpCasts(anyOf(OptionalDerefMatcherImpl, StdMoveCallMatcher));
Finder->addMatcher(
- expr(anyOf(
- // construct optional
- cxxConstructExpr(argumentCountIs(1), hasType(BindOptionalType),
- hasArgument(0, OptionalDerefMatcher)),
- // known template methods in std
- callExpr(
- argumentCountIs(1),
- anyOf(
- // match std::make_unique std::make_shared
- callee(functionDecl(
-
matchers::matchesAnyListedRegexName(MakeSmartPtrList),
- hasTemplateArgument(
- 0, refersToType(BindOptionalType)))),
- // match first std::make_optional by limit argument
count
- // (1) and template count (1).
- // 1. template< class T > constexpr
- // std::optional<decay_t<T>> make_optional(T&&
value);
- // 2. template< class T, class... Args > constexpr
- // std::optional<T> make_optional(Args&&... args);
- callee(functionDecl(templateArgumentCountIs(1),
- hasName(MakeOptional),
- returns(BindOptionalType)))),
- hasArgument(0, OptionalDerefMatcher)),
- callExpr(argumentCountIs(1),
-
- hasArgument(0, OptionalDerefMatcher))),
- unless(anyOf(hasAncestor(typeLoc()),
- hasAncestor(expr(matchers::hasUnevaluatedContext())))))
+ expr(
+ anyOf(
+ // construct optional
+ cxxConstructExpr(argumentCountIs(1), hasType(BindOptionalType),
+ hasArgument(0, OptionalDerefMatcher)),
+ // known template methods in std
+ callExpr(
+ argumentCountIs(1),
+ anyOf(
+ // match std::make_unique std::make_shared
+ callee(functionDecl(
+
matchers::matchesAnyListedRegexName(MakeSmartPtrList),
+ hasTemplateArgument(0,
+
refersToType(BindOptionalType)))),
+ // match first std::make_optional by limit argument count
+ // (1) and template count (1).
+ // 1. template< class T > constexpr
+ // std::optional<decay_t<T>> make_optional(T&& value);
+ // 2. template< class T, class... Args > constexpr
+ // std::optional<T> make_optional(Args&&... args);
+ callee(functionDecl(templateArgumentCountIs(1),
+ hasName(MakeOptional),
+ returns(BindOptionalType)))),
+ hasArgument(0, OptionalDerefMatcher)),
+ callExpr(argumentCountIs(1),
+
+ hasArgument(0, OptionalDerefMatcher))),
+ unless(anyOf(hasAncestor(typeLoc()),
+ hasAncestor(expr(matchers::hasUnevaluatedContext())))))
.bind("expr"),
this);
}
diff --git
a/clang-tools-extra/clang-tidy/bugprone/SuspiciousStringviewDataUsageCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/SuspiciousStringviewDataUsageCheck.cpp
index cc69722a2..342a6e848 100644
---
a/clang-tools-extra/clang-tidy/bugprone/SuspiciousStringviewDataUsageCheck.cpp
+++
b/clang-tools-extra/clang-tidy/bugprone/SuspiciousStringviewDataUsageCheck.cpp
@@ -48,9 +48,9 @@ void
SuspiciousStringviewDataUsageCheck::registerMatchers(MatchFinder *Finder) {
initListExpr(
hasType(qualType(hasCanonicalType(hasDeclaration(recordDecl()))))));
- auto DataMethod =
- cxxMethodDecl(hasName("data"),
-
ofClass(matchers::matchesAnyListedRegexName(StringViewTypes)));
+ auto DataMethod = cxxMethodDecl(
+ hasName("data"),
+ ofClass(matchers::matchesAnyListedRegexName(StringViewTypes)));
auto SizeCall = cxxMemberCallExpr(
callee(cxxMethodDecl(hasAnyName("size", "length"))),
@@ -73,13 +73,14 @@ void
SuspiciousStringviewDataUsageCheck::registerMatchers(MatchFinder *Finder) {
ignoringParenImpCasts(equalsBoundNode("data-call"))),
unless(hasAnyArgument(ignoringParenImpCasts(SizeCall))),
unless(hasAnyArgument(DescendantSizeCall)),
- hasDeclaration(namedDecl(
-
unless(matchers::matchesAnyListedRegexName(AllowedCallees))))),
- initListExpr(expr().bind("parent"),
- hasType(qualType(hasCanonicalType(hasDeclaration(
-
recordDecl(unless(matchers::matchesAnyListedRegexName(
- AllowedCallees))))))),
- unless(DescendantSizeCall)))))),
+ hasDeclaration(namedDecl(unless(
+ matchers::matchesAnyListedRegexName(AllowedCallees))))),
+ initListExpr(
+ expr().bind("parent"),
+ hasType(qualType(hasCanonicalType(hasDeclaration(
+ recordDecl(unless(matchers::matchesAnyListedRegexName(
+ AllowedCallees))))))),
+ unless(DescendantSizeCall)))))),
this);
}
diff --git a/clang-tools-extra/clang-tidy/bugprone/UnsafeFunctionsCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/UnsafeFunctionsCheck.cpp
index b8cc29d91..87d36e3c8 100644
--- a/clang-tools-extra/clang-tidy/bugprone/UnsafeFunctionsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/UnsafeFunctionsCheck.cpp
@@ -247,7 +247,8 @@ void UnsafeFunctionsCheck::registerMatchers(MatchFinder
*Finder) {
for (const auto &Entry : CustomFunctions)
FunctionNames.emplace_back(Entry.Name);
- auto CustomFunctionsMatcher =
matchers::matchesAnyListedRegexName(FunctionNames);
+ auto CustomFunctionsMatcher =
+ matchers::matchesAnyListedRegexName(FunctionNames);
Finder->addMatcher(declRefExpr(to(functionDecl(CustomFunctionsMatcher)
.bind(CustomFunctionNamesId)))
diff --git
a/clang-tools-extra/clang-tidy/bugprone/UnusedLocalNonTrivialVariableCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/UnusedLocalNonTrivialVariableCheck.cpp
index a8a2f53d3..956d5048b 100644
---
a/clang-tools-extra/clang-tidy/bugprone/UnusedLocalNonTrivialVariableCheck.cpp
+++
b/clang-tools-extra/clang-tidy/bugprone/UnusedLocalNonTrivialVariableCheck.cpp
@@ -69,13 +69,13 @@ void
UnusedLocalNonTrivialVariableCheck::registerMatchers(MatchFinder *Finder) {
unless(isExceptionVariable()), hasLocalStorage(), isDefinition(),
unless(hasType(isReferenceType())), unless(hasType(isTrivial())),
unless(explicitMarkUnused()),
- hasType(hasUnqualifiedDesugaredType(
- anyOf(recordType(hasDeclaration(namedDecl(
- matchesAnyListedRegexName(IncludeTypes),
- unless(matchesAnyListedRegexName(ExcludeTypes))))),
- templateSpecializationType(hasDeclaration(namedDecl(
- matchesAnyListedRegexName(IncludeTypes),
-
unless(matchesAnyListedRegexName(ExcludeTypes)))))))))
+ hasType(hasUnqualifiedDesugaredType(anyOf(
+ recordType(hasDeclaration(namedDecl(
+ matchesAnyListedRegexName(IncludeTypes),
+ unless(matchesAnyListedRegexName(ExcludeTypes))))),
+ templateSpecializationType(hasDeclaration(namedDecl(
+ matchesAnyListedRegexName(IncludeTypes),
+ unless(matchesAnyListedRegexName(ExcludeTypes)))))))))
.bind("var"),
this);
}
diff --git a/clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
index 3b9fc0709..7aee725ca 100644
--- a/clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp
@@ -171,18 +171,18 @@ void
UnusedReturnValueCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
}
void UnusedReturnValueCheck::registerMatchers(MatchFinder *Finder) {
- auto MatchedDirectCallExpr =
- expr(callExpr(callee(functionDecl(
- // Don't match copy or move assignment operator.
- unless(isAssignmentOverloadedOperator()),
- // Don't match void overloads of checked functions.
- unless(returns(voidType())),
-
anyOf(isInstantiatedFrom(matchers::matchesAnyListedRegexName(
- CheckedFunctions)),
- returns(hasCanonicalType(hasDeclaration(
-
namedDecl(matchers::matchesAnyListedRegexName(
- CheckedReturnTypes)))))))))
- .bind("match"));
+ auto MatchedDirectCallExpr = expr(
+ callExpr(callee(functionDecl(
+ // Don't match copy or move assignment operator.
+ unless(isAssignmentOverloadedOperator()),
+ // Don't match void overloads of checked functions.
+ unless(returns(voidType())),
+
anyOf(isInstantiatedFrom(matchers::matchesAnyListedRegexName(
+ CheckedFunctions)),
+ returns(hasCanonicalType(hasDeclaration(
+ namedDecl(matchers::matchesAnyListedRegexName(
+ CheckedReturnTypes)))))))))
+ .bind("match"));
auto CheckCastToVoid =
AllowCastToVoid ? castExpr(unless(hasCastKind(CK_ToVoid))) : castExpr();
diff --git a/clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
index f73f138b4..a31dd1e5d 100644
--- a/clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
@@ -138,11 +138,12 @@ makeReinitMatcher(const ValueDecl *MovedVariable,
hasAttr(clang::attr::Reinitializes)))),
// Functions that are specified in ReinitializationFunctions
// option.
-
callExpr(callee(functionDecl(matchers::matchesAnyListedRegexName(
- ReinitializationFunctions))),
- anyOf(cxxMemberCallExpr(on(DeclRefMatcher)),
- callExpr(unless(cxxMemberCallExpr()),
- hasArgument(0, DeclRefMatcher)))),
+ callExpr(
+ callee(functionDecl(matchers::matchesAnyListedRegexName(
+ ReinitializationFunctions))),
+ anyOf(cxxMemberCallExpr(on(DeclRefMatcher)),
+ callExpr(unless(cxxMemberCallExpr()),
+ hasArgument(0, DeclRefMatcher)))),
// Passing variable to a function as a non-const pointer.
callExpr(forEachArgumentWithParam(
unaryOperator(hasOperatorName("&"),
diff --git a/clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.cpp
b/clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.cpp
index 254761644..762144ea6 100644
--- a/clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.cpp
@@ -98,8 +98,8 @@ void ConstCorrectnessCheck::registerMatchers(MatchFinder
*Finder) {
hasType(referenceType(pointee(hasCanonicalType(templateTypeParmType())))),
hasType(referenceType(pointee(substTemplateTypeParmType()))));
- auto AllowedTypeDecl = namedDecl(
- anyOf(matchers::matchesAnyListedRegexName(AllowedTypes),
usingShadowDecl()));
+ auto AllowedTypeDecl = namedDecl(anyOf(
+ matchers::matchesAnyListedRegexName(AllowedTypes), usingShadowDecl()));
const auto AllowedType = hasType(qualType(
anyOf(hasDeclaration(AllowedTypeDecl), references(AllowedTypeDecl),
diff --git
a/clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitializationCheck.cpp
b/clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitializationCheck.cpp
index 05f9caa3c..d4566bc59 100644
---
a/clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitializationCheck.cpp
+++
b/clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitializationCheck.cpp
@@ -93,8 +93,8 @@ AST_MATCHER_FUNCTION_P(StatementMatcher,
// Access through dereference, typically used for `operator[]`:
`(*a)[3]`.
unaryOperator(hasOperatorName("*"), hasUnaryOperand(ReceiverExpr)));
const auto ReceiverType =
- hasCanonicalType(recordType(hasDeclaration(namedDecl(
-
unless(matchers::matchesAnyListedRegexName(ExcludedContainerTypes))))));
+ hasCanonicalType(recordType(hasDeclaration(namedDecl(unless(
+ matchers::matchesAnyListedRegexName(ExcludedContainerTypes))))));
return expr(
anyOf(cxxMemberCallExpr(callee(MethodDecl), on(OnExpr),
diff --git
a/clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp
b/clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp
index 61f66f0e0..ffb2a81b8 100644
--- a/clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp
+++ b/clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp
@@ -51,11 +51,11 @@ UnnecessaryValueParamCheck::UnnecessaryValueParamCheck(
void UnnecessaryValueParamCheck::registerMatchers(MatchFinder *Finder) {
const auto ExpensiveValueParamDecl = parmVarDecl(
- hasType(qualType(
- hasCanonicalType(matchers::isExpensiveToCopy()),
- unless(anyOf(hasCanonicalType(referenceType()),
- hasDeclaration(namedDecl(
-
matchers::matchesAnyListedRegexName(AllowedTypes))))))),
+ hasType(qualType(hasCanonicalType(matchers::isExpensiveToCopy()),
+ unless(anyOf(hasCanonicalType(referenceType()),
+ hasDeclaration(namedDecl(
+ matchers::matchesAnyListedRegexName(
+ AllowedTypes))))))),
decl().bind("param"));
Finder->addMatcher(
traverse(TK_AsIs,
diff --git
a/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
b/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
index 3ccb3cdc9..073fdce50 100644
--- a/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
@@ -217,13 +217,14 @@ void
ContainerSizeEmptyCheck::registerMatchers(MatchFinder *Finder) {
expr(hasType(pointsTo(ValidContainer))).bind("Pointee"))),
expr(hasType(ValidContainer)).bind("STLObject"));
- const auto ExcludedComparisonTypesMatcher = qualType(anyOf(
- hasDeclaration(
-
cxxRecordDecl(matchers::matchesAnyListedRegexName(ExcludedComparisonTypes))
- .bind("excluded")),
- hasCanonicalType(hasDeclaration(
-
cxxRecordDecl(matchers::matchesAnyListedRegexName(ExcludedComparisonTypes))
- .bind("excluded")))));
+ const auto ExcludedComparisonTypesMatcher = qualType(
+ anyOf(hasDeclaration(cxxRecordDecl(matchers::matchesAnyListedRegexName(
+ ExcludedComparisonTypes))
+ .bind("excluded")),
+ hasCanonicalType(hasDeclaration(
+ cxxRecordDecl(matchers::matchesAnyListedRegexName(
+ ExcludedComparisonTypes))
+ .bind("excluded")))));
const auto SameExcludedComparisonTypesMatcher =
qualType(anyOf(hasDeclaration(cxxRecordDecl(equalsBoundNode("excluded"))),
hasCanonicalType(hasDeclaration(
diff --git
a/clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp
b/clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp
index c32b4047b..bb993a60c 100644
--- a/clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp
@@ -51,13 +51,13 @@ void
RedundantParenthesesCheck::registerMatchers(MatchFinder *Finder) {
expr(anyOf(integerLiteral(), floatLiteral(), characterLiteral(),
cxxBoolLiteral(), stringLiteral(), cxxNullPtrLiteralExpr()));
Finder->addMatcher(
- parenExpr(
- subExpr(anyOf(parenExpr(), ConstantExpr,
- declRefExpr(to(namedDecl(unless(
-
matchers::matchesAnyListedRegexName(AllowedDecls))))))),
- unless(anyOf(isInMacro(),
- // sizeof(...) is common used.
- hasParent(unaryExprOrTypeTraitExpr()))))
+ parenExpr(subExpr(anyOf(
+ parenExpr(), ConstantExpr,
+ declRefExpr(to(namedDecl(unless(
+
matchers::matchesAnyListedRegexName(AllowedDecls))))))),
+ unless(anyOf(isInMacro(),
+ // sizeof(...) is common used.
+ hasParent(unaryExprOrTypeTraitExpr()))))
.bind("dup"),
this);
}
diff --git
a/clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp
b/clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp
index b8925c573..3547c67d2 100644
--- a/clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp
@@ -154,11 +154,11 @@ void RedundantStringCStrCheck::registerMatchers(
// Detect redundant 'c_str()' calls in parameters passed to std::format in
// C++20 onwards and std::print in C++23 onwards.
Finder->addMatcher(
- traverse(TK_AsIs,
-
callExpr(callee(functionDecl(matchers::matchesAnyListedRegexName(
- StringParameterFunctions))),
- forEachArgumentWithParam(StringCStrCallExpr,
- parmVarDecl()))),
+ traverse(TK_AsIs, callExpr(callee(functionDecl(
+ matchers::matchesAnyListedRegexName(
+ StringParameterFunctions))),
+ forEachArgumentWithParam(StringCStrCallExpr,
+ parmVarDecl()))),
this);
}
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/174414
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
