yaxunl marked 10 inline comments as done.
yaxunl added inline comments.
================
Comment at: include/clang/Basic/SyncScope.h:21
+/// \brief Defines the synch scope values used by the atomic builtins and
+/// expressions
+enum class SyncScope {
----------------
rjmccall wrote:
> If the numeric values here were chosen to align with the arguments to some
> runtime function, that's important to leave as a comment.
I have added the comments and updated the review.. On the Phabricator web page,
it may take a bit effort to find it since it is interleaved with reviewers'
comments.
https://reviews.llvm.org/D28691
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
