llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-libunwind Author: willmafh (willmafh) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/174565.diff 10 Files Affected: - (modified) libunwind/include/libunwind.h (+1-1) - (modified) libunwind/include/mach-o/compact_unwind_encoding.h (+1-1) - (modified) libunwind/include/unwind_itanium.h (+1-1) - (modified) libunwind/src/FrameHeaderCache.hpp (+1-1) - (modified) libunwind/src/Registers.hpp (+5-5) - (modified) libunwind/src/UnwindCursor.hpp (+3-3) - (modified) libunwind/src/UnwindLevel1-gcc-ext.c (+1-1) - (modified) libunwind/src/UnwindLevel1.c (+1-1) - (modified) libunwind/src/libunwind.cpp (+2-2) - (modified) libunwind/src/libunwind_ext.h (+2-2) ``````````diff diff --git a/libunwind/include/libunwind.h b/libunwind/include/libunwind.h index 56ca7110274a3..6c2dfe58e53bf 100644 --- a/libunwind/include/libunwind.h +++ b/libunwind/include/libunwind.h @@ -122,7 +122,7 @@ __unwind_ptrauth_restricted_intptr(ptrauth_key_function_pointer, 1, \ __ptrauth_unwind_cie_info_personality_disc) - // ptrauth_string_discriminator("personality") == 0x7EAD) + // ptrauth_string_discriminator("personality") == 0x7EAD #define __ptrauth_unwind_pauthtest_personality_disc 0x7EAD #else diff --git a/libunwind/include/mach-o/compact_unwind_encoding.h b/libunwind/include/mach-o/compact_unwind_encoding.h index 4c48e33c3c177..c495b83c40b90 100644 --- a/libunwind/include/mach-o/compact_unwind_encoding.h +++ b/libunwind/include/mach-o/compact_unwind_encoding.h @@ -443,7 +443,7 @@ struct unwind_info_section_header_lsda_index_entry struct unwind_info_regular_second_level_entry { - uint32_t functionOffset; + uint32_t functionOffset; compact_unwind_encoding_t encoding; }; diff --git a/libunwind/include/unwind_itanium.h b/libunwind/include/unwind_itanium.h index d94a6183be290..860ad36cdf14e 100644 --- a/libunwind/include/unwind_itanium.h +++ b/libunwind/include/unwind_itanium.h @@ -32,7 +32,7 @@ struct _Unwind_Exception { // The implementation of _Unwind_Exception uses an attribute mode on the // above fields which has the side effect of causing this whole struct to // round up to 32 bytes in size (48 with SEH). To be more explicit, we add - // pad fields added for binary compatibility. + // pad fields for binary compatibility. uint32_t reserved[3]; #endif // The Itanium ABI requires that _Unwind_Exception objects are "double-word diff --git a/libunwind/src/FrameHeaderCache.hpp b/libunwind/src/FrameHeaderCache.hpp index 296064d8e2e67..caea29e097464 100644 --- a/libunwind/src/FrameHeaderCache.hpp +++ b/libunwind/src/FrameHeaderCache.hpp @@ -24,7 +24,7 @@ #define _LIBUNWIND_FRAMEHEADERCACHE_TRACE(msg, ...) #endif -// This cache should only be be used from within a dl_iterate_phdr callback. +// This cache should only be used from within a dl_iterate_phdr callback. // dl_iterate_phdr does the necessary synchronization to prevent problems // with concurrent access via the libc load lock. Adding synchronization // for other uses is possible, but not currently done. diff --git a/libunwind/src/Registers.hpp b/libunwind/src/Registers.hpp index 474b17461bf77..87314d8265879 100644 --- a/libunwind/src/Registers.hpp +++ b/libunwind/src/Registers.hpp @@ -1893,7 +1893,7 @@ class _LIBUNWIND_HIDDEN Registers_arm64 { uint64_t value = _registers.__pc; #if defined(_LIBUNWIND_TARGET_AARCH64_AUTHENTICATED_UNWINDING) // Note the value of the PC was signed to its address in the register state - // but everyone else expects it to be sign by the SP, so convert on return. + // but everyone else expects it to be signed by the SP, so convert on return. value = (uint64_t)ptrauth_auth_and_resign((void *)_registers.__pc, ptrauth_key_return_address, &_registers.__pc, @@ -3715,21 +3715,21 @@ inline void Registers_sparc::setRegister(int regNum, uint32_t value) { inline bool Registers_sparc::validFloatRegister(int) const { return false; } inline double Registers_sparc::getFloatRegister(int) const { - _LIBUNWIND_ABORT("no Sparc float registers"); + _LIBUNWIND_ABORT("no sparc float registers"); } inline void Registers_sparc::setFloatRegister(int, double) { - _LIBUNWIND_ABORT("no Sparc float registers"); + _LIBUNWIND_ABORT("no sparc float registers"); } inline bool Registers_sparc::validVectorRegister(int) const { return false; } inline v128 Registers_sparc::getVectorRegister(int) const { - _LIBUNWIND_ABORT("no Sparc vector registers"); + _LIBUNWIND_ABORT("no sparc vector registers"); } inline void Registers_sparc::setVectorRegister(int, v128) { - _LIBUNWIND_ABORT("no Sparc vector registers"); + _LIBUNWIND_ABORT("no sparc vector registers"); } inline const char *Registers_sparc::getRegisterName(int regNum) { diff --git a/libunwind/src/UnwindCursor.hpp b/libunwind/src/UnwindCursor.hpp index 5838dbcaa9980..ff92c9e0a844a 100644 --- a/libunwind/src/UnwindCursor.hpp +++ b/libunwind/src/UnwindCursor.hpp @@ -963,7 +963,7 @@ template <typename A, typename R> bool UnwindCursor<A, R>::isSignalFrame() { /// UnwindCursor contains all state (including all register values) during /// an unwind. This is normally stack allocated inside a unw_cursor_t. template <typename A, typename R> -class UnwindCursor : public AbstractUnwindCursor{ +class UnwindCursor : public AbstractUnwindCursor { typedef typename A::pint_t pint_t; public: UnwindCursor(unw_context_t *context, A &as); @@ -2037,7 +2037,7 @@ bool UnwindCursor<A, R>::getInfoFromCompactEncodingSection( if (personalityIndex != 0) { --personalityIndex; // change 1-based to zero-based index if (personalityIndex >= sectionHeader.personalityArrayCount()) { - _LIBUNWIND_DEBUG_LOG("found encoding 0x%08X with personality index %d, " + _LIBUNWIND_DEBUG_LOG("found encoding 0x%08X with personality index %d, " "but personality table has only %d entries", encoding, personalityIndex, sectionHeader.personalityArrayCount()); @@ -3256,7 +3256,7 @@ int UnwindCursor<A, R>::stepThroughSigReturn() { template <typename A, typename R> int UnwindCursor<A, R>::step(bool stage2) { (void)stage2; - // Bottom of stack is defined is when unwind info cannot be found. + // Bottom of stack is defined when unwind info cannot be found. if (_unwindInfoMissing) return UNW_STEP_END; diff --git a/libunwind/src/UnwindLevel1-gcc-ext.c b/libunwind/src/UnwindLevel1-gcc-ext.c index 32c872ffade1f..1764499b304f1 100644 --- a/libunwind/src/UnwindLevel1-gcc-ext.c +++ b/libunwind/src/UnwindLevel1-gcc-ext.c @@ -284,7 +284,7 @@ _LIBUNWIND_EXPORT void __deregister_frame(const void *fde) { // before 10.6 used keymgr to track known FDEs, but these functions // never got updated to use keymgr. // For now, we implement these as do-nothing functions to keep any existing -// applications working. We also add the not in 10.6 symbol so that nwe +// applications working. We also add the not in 10.6 symbol so that new // application won't be able to use them. #if defined(_LIBUNWIND_SUPPORT_FRAME_APIS) diff --git a/libunwind/src/UnwindLevel1.c b/libunwind/src/UnwindLevel1.c index 7368b3cb80336..834fdae6a76d3 100644 --- a/libunwind/src/UnwindLevel1.c +++ b/libunwind/src/UnwindLevel1.c @@ -14,7 +14,7 @@ // ARM EHABI does not specify _Unwind_{Get,Set}{GR,IP}(). Thus, we are // defining inline functions to delegate the function calls to // _Unwind_VRS_{Get,Set}(). However, some applications might declare the -// function protetype directly (instead of including <unwind.h>), thus we need +// function prototype directly (instead of including <unwind.h>), thus we need // to export these functions from libunwind.so as well. #define _LIBUNWIND_UNWIND_LEVEL1_EXTERNAL_LINKAGE 1 diff --git a/libunwind/src/libunwind.cpp b/libunwind/src/libunwind.cpp index 7ffffc2a30c0a..a795e68c57859 100644 --- a/libunwind/src/libunwind.cpp +++ b/libunwind/src/libunwind.cpp @@ -32,7 +32,7 @@ using namespace libunwind; -/// internal object to represent this processes address space +/// internal object to represent this process's address space LocalAddressSpace LocalAddressSpace::sThisAddressSpace; _LIBUNWIND_EXPORT unw_addr_space_t unw_local_addr_space = @@ -306,7 +306,7 @@ _LIBUNWIND_HIDDEN int __unw_is_fpreg(unw_cursor_t *cursor, } _LIBUNWIND_WEAK_ALIAS(__unw_is_fpreg, unw_is_fpreg) -/// Checks if a register is a floating-point register. +/// Get name of specified register at cursor position in stack frame. _LIBUNWIND_HIDDEN const char *__unw_regname(unw_cursor_t *cursor, unw_regnum_t regNum) { _LIBUNWIND_TRACE_API("__unw_regname(cursor=%p, regNum=%d)", diff --git a/libunwind/src/libunwind_ext.h b/libunwind/src/libunwind_ext.h index b3762c24d7da4..a735017e375ab 100644 --- a/libunwind/src/libunwind_ext.h +++ b/libunwind/src/libunwind_ext.h @@ -120,10 +120,10 @@ typedef int (*unw_find_dynamic_unwind_sections)( extern int __unw_add_find_dynamic_unwind_sections( unw_find_dynamic_unwind_sections find_dynamic_unwind_sections); -// Deregister a dynacim unwind-info lookup callback. +// Deregister a dynamic unwind-info lookup callback. // // Returns UNW_ESUCCESS for successful deregistrations. If the given callback -// has already been registered then UNW_EINVAL will be returned. +// does not present then UNW_EINVAL will be returned. extern int __unw_remove_find_dynamic_unwind_sections( unw_find_dynamic_unwind_sections find_dynamic_unwind_sections); `````````` </details> https://github.com/llvm/llvm-project/pull/174565 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
