================
@@ -577,11 +577,11 @@ mlir::Value
CIRAttrToValue::visitCirAttr(cir::GlobalViewAttr globalAttr) {
mlir::LLVM::GEPNoWrapFlags::none);
}
- // The incubator has handling here for the attribute having integer type, but
- // the only test case I could find that reaches it is a direct CIR-to-LLVM IR
- // lowering with no clear indication of how the CIR might have been
generated.
- // We'll hit the unreachable below if this happens.
- assert(!cir::MissingFeatures::globalViewIntLowering());
+ if (auto intTy = mlir::dyn_cast<cir::IntType>(globalAttr.getType())) {
+ auto llvmDstTy = converter->convertType(globalAttr.getType());
----------------
erichkeane wrote:
use of auto.
https://github.com/llvm/llvm-project/pull/174640
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits