JustinStitt wrote: @nickdesaulniers > Hmm...I think we can improve the ergonomics here a little bit. I feel like it > should be possible to have 2 modes instead of three. Like in CGCall if > `-gline-directives-only` or higher is set, then we can elide the `srcloc`. > Then when a dontcall is triggered we scan for (possibly absent) debug info. > If that doesn't exist, fall back to looking for `srcloc`. idk, something just > feels off about a ternary flag, with a second flag required to use one of the > the three states. Most flags are binary, and perhaps the tacked on note > diagnostic that says "enable debug info for additional information" is > palatable and simpler for users?
I've changed over to a binary flag in e866945f1c61774e745ec3a793629104ef473fee wherein we use debug info if it exists and otherwise we use the heuristic with manual srcloc annotations. How does it look? https://github.com/llvm/llvm-project/pull/174892 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
