gtbercea added a comment. In https://reviews.llvm.org/D29654#835045, @arphaman wrote:
> Hi @gtbercea, > I couldn't reply to the email as cfe-commits didn't even register this > commit somehow, so I'm replying here. > > Unfortunately I had to revert this commit (r310291), + two others for a clean > revert (r310300 and r310332) because it caused a test failure on macOS. This > particular run line: > > // RUN: %clang -### -no-canonical-prefixes -fopenmp=libomp > -fopenmp-targets=nvptx64-nvidia-cuda -save-temps -no-canonical-prefixes %t1.o > %t2.o 2>&1 \ > // RUN: | FileCheck -check-prefix=CHK-TWOCUBIN %s > > > Causes the following assertion failure: > > assert(CachedResults.find(ActionTC) != CachedResults.end() && > "Result does not exist??"); > > > Here's a backtrace: > > * frame #0: 0x00007fffbf3a2b2e libsystem_kernel.dylib`__pthread_kill + 10 > frame #1: 0x00007fffbf4c72de libsystem_pthread.dylib`pthread_kill + 303 > frame #2: 0x00007fffbf30041f libsystem_c.dylib`abort + 127 > frame #3: 0x00007fffbf2c9f34 libsystem_c.dylib`__assert_rtn + 320 > frame #4: 0x0000000103a1f2d1 > clang`clang::driver::Driver::BuildJobsForActionNoCache(this=0x00007fff5fbfe4e8, > C=0x0000000111b11830, A=0x0000000111b11ed0, TC=0x0000000112819000, > BoundArch=(Data = "x86_64", Length = 6), AtTopLevel=false, > MultipleArchs=false, LinkingOutput=0x0000000000000000, CachedResults=size=8, > TargetDeviceOffloadKind=OFK_None) const at Driver.cpp:3418 > frame #5: 0x0000000103a1cf11 > clang`clang::driver::Driver::BuildJobsForAction(this=0x00007fff5fbfe4e8, > C=0x0000000111b11830, A=0x0000000111b11ed0, TC=0x0000000112819000, > BoundArch=(Data = "x86_64", Length = 6), AtTopLevel=false, > MultipleArchs=false, LinkingOutput=0x0000000000000000, CachedResults=size=8, > TargetDeviceOffloadKind=OFK_None) const at Driver.cpp:3210 > frame #6: 0x0000000103a1dfb3 > clang`clang::driver::Driver::BuildJobsForActionNoCache(this=0x00007fff5fbfe4e8, > C=0x0000000111b11830, A=0x0000000111b12130, TC=0x0000000112819000, > BoundArch=(Data = "x86_64", Length = 6), AtTopLevel=true, > MultipleArchs=false, LinkingOutput=0x0000000000000000, CachedResults=size=8, > TargetDeviceOffloadKind=OFK_None) const at Driver.cpp:3348 > frame #7: 0x0000000103a1cf11 > clang`clang::driver::Driver::BuildJobsForAction(this=0x00007fff5fbfe4e8, > C=0x0000000111b11830, A=0x0000000111b121f0, TC=0x0000000112819000, > BoundArch=(Data = "x86_64", Length = 6), AtTopLevel=true, > MultipleArchs=false, LinkingOutput=0x0000000000000000, CachedResults=size=8, > TargetDeviceOffloadKind=OFK_None) const at Driver.cpp:3210 > frame #8: 0x0000000103a1db3e > clang`clang::driver::Driver::BuildJobsForActionNoCache(this=0x00007fff5fbfe4e8, > C=0x0000000111b11830, A=0x0000000111b11bf0, TC=0x0000000112819000, > BoundArch=(Data = 0x0000000000000000, Length = 0), AtTopLevel=true, > MultipleArchs=false, LinkingOutput=0x0000000000000000, CachedResults=size=8, > TargetDeviceOffloadKind=OFK_None) const at Driver.cpp:3310 > frame #9: 0x0000000103a1cf11 > clang`clang::driver::Driver::BuildJobsForAction(this=0x00007fff5fbfe4e8, > C=0x0000000111b11830, A=0x0000000111b11bf0, TC=0x0000000112819000, > BoundArch=(Data = 0x0000000000000000, Length = 0), AtTopLevel=true, > MultipleArchs=false, LinkingOutput=0x0000000000000000, CachedResults=size=8, > TargetDeviceOffloadKind=OFK_None) const at Driver.cpp:3210 > frame #10: 0x0000000103a0a5c2 > clang`clang::driver::Driver::BuildJobs(this=0x00007fff5fbfe4e8, > C=0x0000000111b11830) const at Driver.cpp:2843 > frame #11: 0x0000000103a00b5c > clang`clang::driver::Driver::BuildCompilation(this=0x00007fff5fbfe4e8, > ArgList=ArrayRef<const char *> @ 0x00007fff5fbfc1e8) at Driver.cpp:746 > frame #12: 0x0000000100005a52 clang`main(argc_=9, > argv_=0x00007fff5fbff670) at driver.cpp:463 > frame #13: 0x00007fffbf260c05 libdyld.dylib`start + 1 > > > Could you please take a look? > > Let me know if you need anything else, > Cheers, > Alex Hi Alex, I have a fix for the failing test. What's the easiest way to do this? Do I have to commit those patches again or can you push them back in and then I also push the fix? Thanks, --Doru -- https://reviews.llvm.org/D29654 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits