================ @@ -27,6 +27,8 @@ std::unique_ptr<Pass> createHoistAllocasPass(); std::unique_ptr<Pass> createLoweringPreparePass(); std::unique_ptr<Pass> createLoweringPreparePass(clang::ASTContext *astCtx); std::unique_ptr<Pass> createGotoSolverPass(); +std::unique_ptr<Pass> createIdiomRecognizerPass(); +std::unique_ptr<Pass> createIdiomRecognizerPass(clang::ASTContext *astCtx); ---------------- andykaylor wrote:
> > this pass should still live on as a sort of testing platform for such > > exploration > > @andykaylor can you clarify what testing platform suggestion means? I think what I was trying to say was that if we moved mature parts of the idiom recognition into CIR generation (rather than requiring the idiom recognizer pass to produce them) the idiom recognizer pass could still be useful for trying out new optimizations involving specialized representation of C/C++ idioms before that representation was moved into CIR generation. Assuming this is what I meant, "testing platform" was a poor word choice. I should have said "development platform". What I meant was "trying out an optimization to see if it works and/or is beneficial" which is a different sense of "testing" than would naturally come to mind. https://github.com/llvm/llvm-project/pull/172486 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
