================ @@ -0,0 +1,302 @@ +//===----------------------------------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "BoolBitwiseOperationCheck.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Lex/Lexer.h" +#include <array> +#include <optional> +#include <utility> + +using namespace clang::ast_matchers; + +namespace clang::tidy::misc { + +static const DynTypedNode *ignoreParensTowardsTheRoot(const DynTypedNode *N, + ASTContext *AC) { + if (const auto *S = N->get<Stmt>()) { + if (isa<ParenExpr>(S)) { + auto Parents = AC->getParents(*S); + // FIXME: do we need to consider all `Parents` ? + if (!Parents.empty()) + return ignoreParensTowardsTheRoot(&Parents[0], AC); + } + } + return N; +} + +static bool assignsToBoolean(const BinaryOperator *BinOp, ASTContext *AC) { + TraversalKindScope RAII(*AC, TK_AsIs); + auto Parents = AC->getParents(*BinOp); + + return llvm::any_of(Parents, [&](const DynTypedNode &Parent) { + const auto *S = ignoreParensTowardsTheRoot(&Parent, AC)->get<Stmt>(); + const auto *ICE = dyn_cast_if_present<ImplicitCastExpr>(S); + return ICE ? ICE->getType().getDesugaredType(*AC)->isBooleanType() : false; ---------------- denzor200 wrote:
2/3 of `getDesugaredType` calls have becomed not actual, since the implementation was changed. 1/3 of that calls were removed completely, see https://github.com/llvm/llvm-project/pull/167552/changes/f84b2d82613178b829daf26b9d43b897622e2d0d. Also I've added more tests to show that we don't want either `getCanonicalType` or `getDesugaredType` for this case - everything works fine for `isVolatileQualified` check https://github.com/llvm/llvm-project/pull/167552 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
