https://github.com/vbvictor approved this pull request.

LGTM, but please wait for @zeyi2 since he explicitly requested changes. (There 
was recent discussion about blocking review 
https://discourse.llvm.org/t/merging-prs-that-have-a-changes-requested-annotation-when-the-reviewer-is-away/89463).

--------------------------------------------------------

On a side note, we should not "request changes" explicitly unless it's a major 
blocker. 

https://github.com/llvm/llvm-project/pull/172170
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to