================
@@ -0,0 +1,126 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "UseVectorUtilsCheck.h"
+#include "clang/AST/ASTContext.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/Lex/Lexer.h"
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::llvm_check {
+
+UseVectorUtilsCheck::UseVectorUtilsCheck(StringRef Name,
+ ClangTidyContext *Context)
+ : ClangTidyCheck(Name, Context),
+ Inserter(Options.getLocalOrGlobal("IncludeStyle",
+ utils::IncludeSorter::IS_LLVM),
+ areDiagsSelfContained()) {}
+
+void UseVectorUtilsCheck::registerPPCallbacks(const SourceManager &SM,
+ Preprocessor *PP,
+ Preprocessor *ModuleExpanderPP) {
+ Inserter.registerPreprocessor(PP);
+}
+
+void UseVectorUtilsCheck::registerMatchers(MatchFinder *Finder) {
+ // Match `llvm::to_vector(llvm::map_range(X, F))`.
+ Finder->addMatcher(
+ callExpr(callee(functionDecl(hasName("::llvm::to_vector"))),
+ hasArgument(0, callExpr(callee(functionDecl(
+ hasName("::llvm::map_range"))))
+ .bind("inner_call")))
+ .bind("map_range_call"),
+ this);
+
+ // Match `llvm::to_vector(llvm::make_filter_range(X, Pred))`.
+ Finder->addMatcher(
+ callExpr(callee(functionDecl(hasName("::llvm::to_vector"))),
+ hasArgument(0, callExpr(callee(functionDecl(hasName(
+ "::llvm::make_filter_range"))))
+ .bind("inner_call")))
+ .bind("filter_range_call"),
+ this);
+}
+
+void UseVectorUtilsCheck::check(const MatchFinder::MatchResult &Result) {
+ const auto *MapRangeCall =
Result.Nodes.getNodeAs<CallExpr>("map_range_call");
+ const auto *FilterRangeCall =
+ Result.Nodes.getNodeAs<CallExpr>("filter_range_call");
+ if (!MapRangeCall && !FilterRangeCall)
+ return;
+
+ const auto *InnerCall = Result.Nodes.getNodeAs<CallExpr>("inner_call");
+ assert(InnerCall && "inner_call must be bound if map_range_call or "
+ "filter_range_call matched");
+ // Only handle the 2-argument overloads of `map_range`/`make_filter_range`,
to
+ // future-proof against additional overloads.
+ if (InnerCall->getNumArgs() != 2)
----------------
zwuis wrote:
We can move this logic to the matcher.
```cpp
callExpr(
...,
argumentCountIs(2))
```
https://github.com/llvm/llvm-project/pull/177722
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
