=?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]>, =?utf-8?q?Balázs_Kéri?= <[email protected]> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
vbvictor wrote: > Should we fix the "linter errors"? The shown output is not in human-readable > form. For now it's raw output from clang-tidy. What should be the readable form in terms of github? These comments are not rendered in UI because it may produce a lot of noise for human-reviewers. > Some results are not applicable to the code, for example nodes_begin and > nodes_end should have this standard name to be used by the graph algorithm > template. Yeah, `nodes_end`, `nodes_begin`, `child_end`, `child_begin` can be suppressed by `//NOLINT` (and ignored later in main config), other comments seem valid to me. Or is `GetValue` also needs to be exaclty start with capital? https://github.com/llvm/llvm-project/pull/175342 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
