sdardis requested changes to this revision. sdardis added a comment. This revision now requires changes to proceed.
Follow @atanasyan 's suggestion and post a patch that renames that enum along with other changes. One comment inlined. ================ Comment at: clang/Basic/DiagnosticDriverKinds.td:282-287 +def warn_target_unsupported_abslegacy : Warning< + "ignoring '-mabs=legacy' option because the '%0' architecture does not support it">, + InGroup<UnsupportedAbs>; +def warn_target_unsupported_abs2008 : Warning< + "ignoring '-mabs=2008' option because the '%0' architecture does not support it">, + InGroup<UnsupportedAbs>; ---------------- These require tests. You should test that abs2008 is ignored pre-r2, legacy and abs2008 is accepted up to r5 and legacy is ignored for R6. Repository: rL LLVM https://reviews.llvm.org/D35982 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
