arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: test/Tooling/clang-diff-ast.cpp:68 +// nodes from other files are excluded +// CHECK-NOT {{.}} +#include "clang-diff-ast.cpp" ---------------- johannes wrote: > arphaman wrote: > > 1) Missing ':' > > 2) What exactly does this regex accomplish? Right now it will match any > > character which doesn't look correct > I want to assert that there is no output here, because other files are > excluded, there may be a better way.. Ok, fair enough. https://reviews.llvm.org/D36184 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits