github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp --
clang/lib/CIR/CodeGen/CIRGenCall.cpp clang/test/CIR/CodeGen/misc-attrs.cpp
mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp
mlir/lib/Target/LLVMIR/ModuleImport.cpp
mlir/lib/Target/LLVMIR/ModuleTranslation.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/CIR/CodeGen/CIRGenCall.cpp
b/clang/lib/CIR/CodeGen/CIRGenCall.cpp
index 34e0309e3..809d775e7 100644
--- a/clang/lib/CIR/CodeGen/CIRGenCall.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenCall.cpp
@@ -227,11 +227,11 @@ void CIRGenModule::constructAttributeList(llvm::StringRef
name,
modularFormat->getImplName()};
llvm::append_range(args, modularFormat->aspects());
attrs.set(cir::CIRDialect::getModularFormatAttrName(),
- builder.getStringAttr(llvm::join(args, ",")));
+ builder.getStringAttr(llvm::join(args, ",")));
}
// TODO(cir): We should set nobuiltin and default function attrs here.
-
+
// TODO(cir): There is another region of `if (targetDecl)` that handles
// removing some attributes that are necessary modifications of the
// default-function attrs. We should do that here.
diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
index 2ef2a72db..efccbd51d 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
@@ -997,7 +997,8 @@ void CallOp::build(OpBuilder &builder, OperationState
&state, TypeRange results,
/*convergent=*/nullptr, /*no_unwind=*/nullptr, /*will_return=*/nullptr,
/*noreturn=*/nullptr, /*returns_twice=*/nullptr, /*hot=*/nullptr,
/*cold=*/nullptr, /*noduplicate=*/nullptr,
- /*no_caller_saved_registers=*/nullptr, /*nocallback=*/nullptr,
/*modular_format=*/nullptr,
+ /*no_caller_saved_registers=*/nullptr, /*nocallback=*/nullptr,
+ /*modular_format=*/nullptr,
/*op_bundle_operands=*/{}, /*op_bundle_tags=*/{},
/*arg_attrs=*/nullptr, /*res_attrs=*/nullptr,
/*access_groups=*/nullptr, /*alias_scopes=*/nullptr,
@@ -1031,7 +1032,8 @@ void CallOp::build(OpBuilder &builder, OperationState
&state,
/*noreturn=*/nullptr,
/*returns_twice=*/nullptr, /*hot=*/nullptr,
/*cold=*/nullptr, /*noduplicate=*/nullptr,
- /*no_caller_saved_registers=*/nullptr, /*nocallback=*/nullptr,
/*modular_format=*/nullptr,
+ /*no_caller_saved_registers=*/nullptr, /*nocallback=*/nullptr,
+ /*modular_format=*/nullptr,
/*op_bundle_operands=*/{}, /*op_bundle_tags=*/{},
/*arg_attrs=*/nullptr, /*res_attrs=*/nullptr,
/*access_groups=*/nullptr,
@@ -1051,7 +1053,8 @@ void CallOp::build(OpBuilder &builder, OperationState
&state,
/*noreturn=*/nullptr,
/*returns_twice=*/nullptr, /*hot=*/nullptr,
/*cold=*/nullptr, /*noduplicate=*/nullptr,
- /*no_caller_saved_registers=*/nullptr, /*nocallback=*/nullptr,
/*modular_format=*/nullptr,
+ /*no_caller_saved_registers=*/nullptr, /*nocallback=*/nullptr,
+ /*modular_format=*/nullptr,
/*op_bundle_operands=*/{}, /*op_bundle_tags=*/{},
/*arg_attrs=*/nullptr, /*res_attrs=*/nullptr,
/*access_groups=*/nullptr, /*alias_scopes=*/nullptr,
@@ -1071,7 +1074,8 @@ void CallOp::build(OpBuilder &builder, OperationState
&state, LLVMFuncOp func,
/*noreturn=*/nullptr,
/*returns_twice=*/nullptr, /*hot=*/nullptr,
/*cold=*/nullptr, /*noduplicate=*/nullptr,
- /*no_caller_saved_registers=*/nullptr, /*nocallback=*/nullptr,
/*modular_format=*/nullptr,
+ /*no_caller_saved_registers=*/nullptr, /*nocallback=*/nullptr,
+ /*modular_format=*/nullptr,
/*op_bundle_operands=*/{}, /*op_bundle_tags=*/{},
/*access_groups=*/nullptr, /*alias_scopes=*/nullptr,
/*arg_attrs=*/nullptr, /*res_attrs=*/nullptr,
diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
index 7d14efc0b..1d1c0e893 100644
--- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -1686,7 +1686,7 @@ static void convertFunctionAttributes(LLVMFuncOp func,
llvmFunc->addFnAttr(llvm::Attribute::WillReturn);
if (func.getNoreturnAttr())
llvmFunc->addFnAttr(llvm::Attribute::NoReturn);
- if(func.getNoCallerSavedRegistersAttr())
+ if (func.getNoCallerSavedRegistersAttr())
llvmFunc->addFnAttr("no_caller_saved_registers");
if (func.getNocallbackAttr())
llvmFunc->addFnAttr(llvm::Attribute::NoCallback);
``````````
</details>
https://github.com/llvm/llvm-project/pull/178443
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
