arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land.
LGTM, with one request below: ================ Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:96 - /// Finds an edit script that converts T1 to T2. - std::vector<Change> computeChanges(Mapping &M); - - void printChangeImpl(raw_ostream &OS, const Change &Chg) const; - void printMatchImpl(raw_ostream &OS, const Match &M) const; - - // Returns a mapping of identical subtrees. - Mapping matchTopDown() const; + NodeId getMapped(const std::unique_ptr<SyntaxTree::Impl> &Tree, NodeId Id) const { + if (&*Tree == &T1) ---------------- 80 column violation, please re-format. https://reviews.llvm.org/D36179 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits