KFAFSP wrote:

> I do find it strange that we need a distinction between the first declarator 
> and not the first because the message seems to be pointing to the right place

Yes, but see the issue I created for why that doesn't work.

In essence, the location _does_ point to where the type specifier _would need 
to be_, but in a declaration group, the warning/error will be raised for every 
identifier that is declared. So, without the check, you'll get `int int int ` 
in the test that I made. Again, feel free to try the LIT test.

Also, not emitting a FixIt for the subsequent identifiers in the declaration 
group will mean that clang infers that it couldn't fix all the issues in the 
file, and abort the automatic FixIt process. I assume we also don't want that, 
because we quite clearly were able to fix it.



https://github.com/llvm/llvm-project/pull/179356
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to