AbhinavPradeep wrote:

> I really like this direction but I wonder if it would make sense to split 
> this up in 2 PRs. One for the CFG and one for the analysis.

My only worry is that the analysis-related changes are ~30 lines of changes I 
think. So it might be too small as a meaningful PR maybe? A mjority of the 
changes in this PR itself are to the CFG matching test suite, the core 
functionality changes I think are ~200 lines. What are your thoughts on 
splitting this PR @usx95 

https://github.com/llvm/llvm-project/pull/177985
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to