https://github.com/NagyDonat created https://github.com/llvm/llvm-project/pull/180188
These NodeBuilder classes were deleted from the codebase in 2011 (fifteen years ago!) by 3eae33412d18c4a4a4a8592898b3e65ad5946a89 so don't declare them as friends. From 83edeced6016a2de0b8ef4d370621d77576ead13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= <[email protected]> Date: Fri, 6 Feb 2026 13:42:12 +0100 Subject: [PATCH] [NFC][analyzer] Get rid of imaginary friends (of classes) These NodeBuilder classes were deleted from the codebase in 2011 (fifteen years ago!) by 3eae33412d18c4a4a4a8592898b3e65ad5946a89 so don't declare them as friends. --- .../clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h | 2 -- .../clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h | 1 - 2 files changed, 3 deletions(-) diff --git a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h index 75a24827d3e03..96ddd12b286a6 100644 --- a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h +++ b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h @@ -48,8 +48,6 @@ class ExprEngine; /// CoreEngine - Implements the core logic of the graph-reachability analysis. /// It traverses the CFG and generates the ExplodedGraph. class CoreEngine { - friend class CommonNodeBuilder; - friend class EndOfFunctionNodeBuilder; friend class ExprEngine; friend class IndirectGotoNodeBuilder; friend class NodeBuilder; diff --git a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h index bd11e0d40cfa9..29c252472b93d 100644 --- a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h +++ b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h @@ -66,7 +66,6 @@ class ExplodedGraph; class ExplodedNode : public llvm::FoldingSetNode { friend class BranchNodeBuilder; friend class CoreEngine; - friend class EndOfFunctionNodeBuilder; friend class ExplodedGraph; friend class IndirectGotoNodeBuilder; friend class NodeBuilder; _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
