llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tools-extra Author: Zinovy Nis (irishrover) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/180332.diff 3 Files Affected: - (modified) clang-tools-extra/clang-doc/Generators.cpp (+1-1) - (modified) clang-tools-extra/clang-doc/Generators.h (+1-1) - (modified) clang-tools-extra/clang-doc/tool/ClangDocMain.cpp (+2-2) ``````````diff diff --git a/clang-tools-extra/clang-doc/Generators.cpp b/clang-tools-extra/clang-doc/Generators.cpp index fafe41eebb779..eca1f288d5ba1 100644 --- a/clang-tools-extra/clang-doc/Generators.cpp +++ b/clang-tools-extra/clang-doc/Generators.cpp @@ -32,7 +32,7 @@ findGeneratorByName(llvm::StringRef Format) { // Enum conversion -std::string getTagType(TagTypeKind AS) { +llvm::StringRef getTagType(TagTypeKind AS) { switch (AS) { case TagTypeKind::Class: return "class"; diff --git a/clang-tools-extra/clang-doc/Generators.h b/clang-tools-extra/clang-doc/Generators.h index a50f1ac25eda9..ade0bb53eba7e 100644 --- a/clang-tools-extra/clang-doc/Generators.h +++ b/clang-tools-extra/clang-doc/Generators.h @@ -51,7 +51,7 @@ typedef llvm::Registry<Generator> GeneratorRegistry; llvm::Expected<std::unique_ptr<Generator>> findGeneratorByName(llvm::StringRef Format); -std::string getTagType(TagTypeKind AS); +llvm::StringRef getTagType(TagTypeKind AS); llvm::Error createFileOpenError(StringRef FileName, std::error_code EC); diff --git a/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp b/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp index ee4c449718871..bc30f61264174 100644 --- a/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp +++ b/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp @@ -128,7 +128,7 @@ static llvm::cl::opt<OutputFormatTy> static llvm::ExitOnError ExitOnErr; -static std::string getFormatString() { +static llvm::StringRef getFormatString() { switch (FormatEnum) { case OutputFormatTy::yaml: return "yaml"; @@ -263,7 +263,7 @@ Example usage for a project using a compile commands database: llvm::TimeTraceScope("main"); // Fail early if an invalid format was provided. - std::string Format = getFormatString(); + llvm::StringRef Format = getFormatString(); llvm::outs() << "Emiting docs in " << Format << " format.\n"; auto G = ExitOnErr(doc::findGeneratorByName(Format)); `````````` </details> https://github.com/llvm/llvm-project/pull/180332 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
