https://github.com/irishrover created https://github.com/llvm/llvm-project/pull/180335
None >From 7a7d86a67f1c4173c2b0b11cf3187da3d5971c72 Mon Sep 17 00:00:00 2001 From: Zinovy Nis <[email protected]> Date: Sat, 7 Feb 2026 12:30:42 +0300 Subject: [PATCH] [clangd] Apply modernize-use-string-view to the code#180332 --- clang-tools-extra/clangd/Feature.cpp | 2 +- clang-tools-extra/clangd/Feature.h | 3 ++- clang-tools-extra/clangd/SymbolDocumentation.cpp | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/clang-tools-extra/clangd/Feature.cpp b/clang-tools-extra/clangd/Feature.cpp index ec707a33f656b..fbae381911b89 100644 --- a/clang-tools-extra/clangd/Feature.cpp +++ b/clang-tools-extra/clangd/Feature.cpp @@ -30,7 +30,7 @@ std::string platformString() { return PlatformString; } -std::string featureString() { +llvm::StringRef featureString() { return #if defined(_WIN32) "windows" diff --git a/clang-tools-extra/clangd/Feature.h b/clang-tools-extra/clangd/Feature.h index ba958fc49c020..0539a07a3e786 100644 --- a/clang-tools-extra/clangd/Feature.h +++ b/clang-tools-extra/clangd/Feature.h @@ -15,6 +15,7 @@ // Export constants like CLANGD_BUILD_XPC #include "Features.inc" +#include "llvm/ADT/StringRef.h" namespace clang { namespace clangd { @@ -28,7 +29,7 @@ std::string platformString(); // Returns a string describing the compile-time configuration. // e.g. mac+debug+asan+grpc -std::string featureString(); +llvm::StringRef featureString(); } // namespace clangd } // namespace clang diff --git a/clang-tools-extra/clangd/SymbolDocumentation.cpp b/clang-tools-extra/clangd/SymbolDocumentation.cpp index a50d7a565b1bc..37cfa84078590 100644 --- a/clang-tools-extra/clangd/SymbolDocumentation.cpp +++ b/clang-tools-extra/clangd/SymbolDocumentation.cpp @@ -20,7 +20,8 @@ namespace clang { namespace clangd { namespace { -std::string commandMarkerAsString(comments::CommandMarkerKind CommandMarker) { +llvm::StringRef +commandMarkerAsString(comments::CommandMarkerKind CommandMarker) { switch (CommandMarker) { case comments::CommandMarkerKind::CMK_At: return "@"; @@ -33,7 +34,7 @@ std::string commandMarkerAsString(comments::CommandMarkerKind CommandMarker) { void commandToMarkup(markup::Paragraph &Out, StringRef Command, comments::CommandMarkerKind CommandMarker, StringRef Args) { - Out.appendBoldText(commandMarkerAsString(CommandMarker) + Command.str()); + Out.appendBoldText((commandMarkerAsString(CommandMarker) + Command).str()); Out.appendSpace(); if (!Args.empty()) Out.appendCode(Args.str()); _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
