https://github.com/jh7370 commented:
The changes that are purely fixing the RUN directive itself all look good to me, as does the obj2yaml test. However, I'm not sure I have enough contextual knowledge to be able to approve the tests in the other cases. It would be worth adding the authors of those tests and/or active maintainers in the relevant areas to review the changes to see if they are appropriate. You could alternatively split this PR up into individual ones with each non-trivial test change in a separate PR. https://github.com/llvm/llvm-project/pull/179668 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
