[PATCH] D36857: [Driver] Set linkPath and MSVT version when cl.exe is detected, plus STL's hacking.

[Nico Weber via Phabricator via cfe-commits]

thakis added inline comments.


================
Comment at: lib/Driver/ToolChains/MSVC.cpp:135
+      llvm::SmallString<256> TestPath = PathEntry;
+      while(!TestPath.empty()) {
         TestPath = llvm::sys::path::parent_path(TestPath);
----------------
Having a while loop going up the directory tree stating around on every 
compiler invocation for supporting a fairly narrow use case seems a bit 
unfortunate. Maybe we could instead add a flag (or just a cc1 flag, even) to 
override the check instead?


https://reviews.llvm.org/D36857



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits