AaronBallman wrote: > The context here is that there are at least 4 notions of what "max" means for > floating-point numbers that are in common use, and the used semantics should > not hidden behind such an innocuous name.
Because this is a builtin, I agree. > It would probably make more sense to warn if this intrinsic is used with > floats rather than not supporting them entirely. That's how I lean but I don't have a good idea for what the warning conditions would be. I don't think "warn on any float" is viable -- outside of a handful of edge cases, the function does what it says on the tin, right? And the edge cases aren't something we can catch statically in most cases, I believe. https://github.com/llvm/llvm-project/pull/180885 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
