https://github.com/ilovepi commented:
The first comment in the PR is the commit description. While that is a
reasonable comment for reviewers, it is not appropriate for the commit log.
Please update that to be more appropriate and summarize the change being made.
Further, I'm not sure I follow your reasoning in the description. please
elaborate on what you were trying to do with `{{^End}}`. IF there is a real bug
int he mustache implementation, then we should fix that in the mustache
library, but right now it does pass all core Mustache spec conformance tests,
so we'll need an example and to compare that against the formal spec to
determine 1) the right test, and 2) the correct fix.
Lastly, I see you disabled highlighting due to some other issues. We should
determine if we can address that more fundamentally in the template, e.g by
changing the HTML constructs, the CSS, or other properties of the output.
https://github.com/llvm/llvm-project/pull/181417
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
