================ @@ -0,0 +1,18 @@ +set(TARGET_LIBC_ENTRYPOINTS +) ---------------- fineg74 wrote:
I readded some of the entry points although I am not sure I understand the general idea. I.e. we are not running libc tests for any of the platforms and meanwhile there is no specifics about when this testing will be enabled. I don't think it is worth to wait with adding support for various entrypoints for spirv given the fact we have everything for the rest of the platforms and the fact that spirv for gpu is still an experimental platform that is not enabled by default. Moreover, I was contacted by multiple developers who are interested to start using spirv built libc so they can probably start testing it. I understand when it is done to reduce the size of the PR, so it can be readded on the next PRs while keeping size of each PR small, but I am not sure we need to stop working on libc for spirv until testing is in place https://github.com/llvm/llvm-project/pull/181049 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
