saugustine added a reviewer: weimingz. saugustine added inline comments.
================ Comment at: compiler-rt/lib/builtins/CMakeLists.txt:223 + cpu_model.c + divxc3.c + fixxfdi.c ---------------- mgorny wrote: > This and the following files have only: > > ``` > #if !_ARCH_PPC > ``` > > so I suppose it's currently included on more targets than x86. If it's really > not useful there, I think it'd be better to update the `#if`s first (and > preferably get the author to review). As discussed in D36764, these all assume 80-bit floats, and therefore are only useful on x86 (and ancient 68ks)--and, in fact, the tests for these functions are disabled for everything but x86. I have left these #ifs in for now, but will remove them after this patch gets submitted (and add comments about them needing 80-bit floats). Otherwise, powerpc builds will be broken. https://reviews.llvm.org/D36555 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
