https://github.com/teresajohnson commented:
A few other minor questions - my biggest question is why a few of the tests that check the llvm-bcanalyzer output were affected at all. Two other high level suggestions: - "noRenameOnPromotion" would be preferable to "notRenameOnPromotion" - for the new tests please add a one sentence description at the top of what is being tested. https://github.com/llvm/llvm-project/pull/178587 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
