https://github.com/fmayer updated https://github.com/llvm/llvm-project/pull/182624
>From b5fa04bf21ae7d1c7e7be8c5053c1f86aab8d3f1 Mon Sep 17 00:00:00 2001 From: Florian Mayer <[email protected]> Date: Fri, 20 Feb 2026 15:44:56 -0800 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-8?q?itial=20version?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Created using spr 1.3.7 --- clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp index c5b1ed8cfabdc..4bb3ea714039d 100644 --- a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp +++ b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp @@ -419,7 +419,10 @@ class ResultObjectVisitor : public AnalysisASTVisitor { // We treat `BuiltinBitCastExpr` as an "original initializer" too as // it may not even be casting from a record type -- and even if it is, // the two objects are in general of unrelated type. - isa<BuiltinBitCastExpr>(E)) { + isa<BuiltinBitCastExpr>(E) || + // TODO: consider properly progating the Loc into the await_resume() + // of the result of the getOperand(). + isa<CoawaitExpr>(E)) { return; } if (auto *Op = dyn_cast<BinaryOperator>(E); >From c5a118bbf666be41182a2adb015e3715280b7c92 Mon Sep 17 00:00:00 2001 From: Florian Mayer <[email protected]> Date: Fri, 20 Feb 2026 17:23:31 -0800 Subject: [PATCH 2/3] typo Created using spr 1.3.7 --- clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp index 4bb3ea714039d..7c24d1448ab9d 100644 --- a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp +++ b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp @@ -420,7 +420,7 @@ class ResultObjectVisitor : public AnalysisASTVisitor { // it may not even be casting from a record type -- and even if it is, // the two objects are in general of unrelated type. isa<BuiltinBitCastExpr>(E) || - // TODO: consider properly progating the Loc into the await_resume() + // TODO: consider properly propagating the Loc into the await_resume() // of the result of the getOperand(). isa<CoawaitExpr>(E)) { return; >From 69d87d3ccaec20faa1f8fdcbc36f42ac5ac053e0 Mon Sep 17 00:00:00 2001 From: Florian Mayer <[email protected]> Date: Fri, 20 Feb 2026 17:28:34 -0800 Subject: [PATCH 3/3] cmt Created using spr 1.3.7 --- clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp index 7c24d1448ab9d..743d04eff415a 100644 --- a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp +++ b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp @@ -420,8 +420,8 @@ class ResultObjectVisitor : public AnalysisASTVisitor { // it may not even be casting from a record type -- and even if it is, // the two objects are in general of unrelated type. isa<BuiltinBitCastExpr>(E) || - // TODO: consider properly propagating the Loc into the await_resume() - // of the result of the getOperand(). + // The result object of co_await is <op>.await_resume(), but there is + // no expression for that to propagate to. isa<CoawaitExpr>(E)) { return; } _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
