https://github.com/DeinAlptraum commented:
Aside from the inline comments I left below, this will also require - fixing the linter issues - fixing broken tests - adding tests for the new functionality you added - adding a release note - splitting the PR up into smaller pieces - most importantly, this should be split into macro and comment changes, since they are completely unrelated - if possible, splitting the comment-related stuff into smaller pieces would also be preferable, since the changes are already going to be huge once we factor in tests More generally, what's the point of implementing comment support, if none of the bindings functions return them? As far as I can tell there is currently no reasonable way to actually use the `Comment` class through the bindings. Also CC @Endilll https://github.com/llvm/llvm-project/pull/81684 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
