andykaylor wrote: > @andykaylor I realized that this may be a bit of a pain to review. In cases > like this, I was wondering if it was better to just set the `MissingFeatures` > method to true and leave it at that or one-and-done refactors, like this, > were fine.
Generally, we don't like code changes that don't have testable effects. In this case, we're tracking the FP features before we're ready to do anything with them. However, since this is following established behavior from classic codegen that will definitely be needed, I think it's OK to put it in place now. https://github.com/llvm/llvm-project/pull/182187 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
