rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
Please add a test that the attribute is emitted into IR. Other than that, this looks good to me. ================ Comment at: include/clang/Driver/Options.td:645 + profile is accurate, callsites without profile samples are marked + as cold. Otherwise, treat callsites without profile samples as if + we have no profile}]>; ---------------- Consistently use passive voice here: "treat callsites without profile samples" -> "callsites without profile samples are treated" ================ Comment at: include/clang/Driver/Options.td:646 + as cold. Otherwise, treat callsites without profile samples as if + we have no profile}]>; +def fno_profile_sample_accurate : Flag<["-"], "fno-profile-sample-accurate">, ---------------- Add a trailing period. https://reviews.llvm.org/D37091 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
