ampandey-1995 wrote:
> This is still 2 separate changes, neither of which is NFC. Why do you want to > enable internalization on the asan library? The functions really should have > external linkage for the sanitizer pass to emit calls to them. asanrtl.bc correctly emit functions with external linkage after internal [patch](https://github.com/ROCm/llvm-project/pull/1185) . Most of the symbols in asanrtl.bc have __attribute__((used)) in them. Their definitions persist even with internalization enabled . Hi @b-sumner , Does enabling internalization of `asanrtl.bc` cause problems with sanitizer pass? https://github.com/llvm/llvm-project/pull/182825 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
